prevent negotation on connections that dont' require it #38903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-github-robot
added
size/S
ncdc
reviewed
Dec 19, 2016
| @@ -91,6 +91,9 @@ type ClientAccessFactory interface { | |||
| RESTClient() (*restclient.RESTClient, error) | |||
| // Returns a client.Config for accessing the Kubernetes server. | |||
| ClientConfig() (*restclient.Config, error) | |||
| // BareClientConfig returns a client.Config that has NOT been negotiated. It's | |||
| // just directions to the server. People use this to build RESTMappers on top of | |||
There was a problem hiding this comment.
directions?
connection info? address, port, certs, etc
There was a problem hiding this comment.
nvm, was thinking this should have been "direct" but I get it now.
|
LGTM |
deads2k
added
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue (batch tested with PRs 38080, 38903) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all clientconfigs require negotiation. Before there was a patch (hardcoded to an instance variable) that allowed this. This updates the code to allow the same as before.
@kubernetes/sig-cli @fabianofranz
@ncdc you'll want to pick