Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update reference to dns sidecar (was dnsmasq-metrics); remove exec-healthz #38992

Merged
merged 1 commit into from Dec 21, 2016
Merged

Update reference to dns sidecar (was dnsmasq-metrics); remove exec-healthz #38992

merged 1 commit into from Dec 21, 2016

Conversation

bowei
Copy link
Member

@bowei bowei commented Dec 19, 2016 •
edited

-The image path is wrong -- I am waiting for the CI to pass here before pushing to google_containers-

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 19, 2016
@bowei
Copy link
Member Author

bowei commented Dec 19, 2016

@MrHohn

@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Dec 19, 2016
@bowei bowei force-pushed the remove-dns-exec-healthz branch 2 times, most recently from 22e5508 to e749deb Compare December 20, 2016 00:03
@bowei bowei changed the title Update reference to dns side (was dnsmasq-metrics); remove exec-healthz Update reference to dns sidecar (was dnsmasq-metrics); remove exec-healthz Dec 20, 2016
@bowei bowei force-pushed the remove-dns-exec-healthz branch 2 times, most recently from 14c85cd to 71cc872 Compare December 20, 2016 01:08
MrHohn
MrHohn reviewed Dec 20, 2016
View reviewed changes
cluster/addons/dns/kubedns-controller.yaml.base
ports:
- containerPort: 8080
protocol: TCP
memory: 20Mi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline. May want to add cpu request here.

@MrHohn
Copy link
Member

MrHohn commented Dec 20, 2016

And should also keep kubernetes/cluster/juju/layers/kubernetes/templates/kubedns-controller.yaml in sync.

@k8s-ci-robot
Copy link
Contributor

Jenkins Bazel Build failed for commit 2f14df5e3a0f95d1f1b7e4dd4b37c8e17079256c. Full PR test history.

The magic incantation to run this job again is @k8s-bot bazel test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit 2f14df5e3a0f95d1f1b7e4dd4b37c8e17079256c. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit 2f14df5e3a0f95d1f1b7e4dd4b37c8e17079256c. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins Kubemark GCE e2e failed for commit 2f14df5e3a0f95d1f1b7e4dd4b37c8e17079256c. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit 2f14df5e3a0f95d1f1b7e4dd4b37c8e17079256c. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE Node e2e failed for commit 2f14df5e3a0f95d1f1b7e4dd4b37c8e17079256c. Full PR test history.

The magic incantation to run this job again is @k8s-bot node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 2f14df5e3a0f95d1f1b7e4dd4b37c8e17079256c. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit 2f14df5e3a0f95d1f1b7e4dd4b37c8e17079256c. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit 2f14df5e3a0f95d1f1b7e4dd4b37c8e17079256c. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins CRI GCE Node e2e failed for commit 2f14df5e3a0f95d1f1b7e4dd4b37c8e17079256c. Full PR test history.

The magic incantation to run this job again is @k8s-bot cri node e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit 2f14df5e3a0f95d1f1b7e4dd4b37c8e17079256c. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@bowei
Update reference to dns sidecar (was dnsmasq-metrics); remove exec-he…
4177639 
…althz

k8s-dns-sidecar --probe will be used to maintain a health check
of the DNS related daemons. This removes the need for exec-healthz.
@bowei
Copy link
Member Author

bowei commented Dec 21, 2016

@thockin

@thockin thockin added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Dec 21, 2016
@thockin thockin added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 21, 2016
@thockin thockin assigned thockin and unassigned eparis Dec 21, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit e150a6e into kubernetes:master Dec 21, 2016
@bowei bowei deleted the remove-dns-exec-healthz branch December 21, 2016 02:04
@feiskyer feiskyer mentioned this pull request Jun 26, 2018
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHohn MrHohn MrHohn left review comments

Assignees

@thockin thockin

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bowei @k8s-reviewable @MrHohn @k8s-ci-robot @k8s-github-robot @thockin @eparis