Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Glusterfs Vol Plugin]: Check kube client is invalid and return error #39014

Merged
merged 1 commit into from Dec 23, 2016
Merged

[Glusterfs Vol Plugin]: Check kube client is invalid and return error #39014

merged 1 commit into from Dec 23, 2016

Conversation

resouer
Copy link
Contributor

@resouer resouer commented Dec 20, 2016 •
edited

Fixes: #38939

In volume plugins, we need to create a kube client to make api call. And this kube client can be nil when, for example, wrong api-server configuration, but kubelet should not crash in this case.

I have also checked other plugins and found only glusterfs need this fix.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 20, 2016
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Dec 20, 2016
@resouer resouer changed the title Check kube client is valid and return error [Glusterfs Vol Plugin]: Check kube client is valid and return error Dec 20, 2016
@resouer resouer changed the title [Glusterfs Vol Plugin]: Check kube client is valid and return error [Glusterfs Vol Plugin]: Check kube client is invalid and return error Dec 20, 2016
@resouer resouer added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Dec 20, 2016
@resouer resouer requested a review from rootfs December 20, 2016 11:47
@rootfs
Copy link
Contributor

rootfs commented Dec 20, 2016

there is yet another call in collectGids

@rootfs
Copy link
Contributor

rootfs commented Dec 20, 2016

please also check GetClassForVolume in pkg/volume/util/util.go

@resouer
Copy link
Contributor Author

resouer commented Dec 23, 2016

kindly ping @rootfs back ...

@rootfs
Copy link
Contributor

rootfs commented Dec 23, 2016

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 23, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 39029, 39014)

@k8s-github-robot k8s-github-robot merged commit 1c2a23e into kubernetes:master Dec 23, 2016
@resouer resouer deleted the fix-nil-glusterfs branch December 24, 2016 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootfs rootfs Awaiting requested review from rootfs

Assignees

@rootfs rootfs

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

panic: runtime error: invalid memory address or nil pointer dereference -- kubelet
5 participants
@resouer @k8s-reviewable @rootfs @k8s-github-robot @k8s-ci-robot