Moves e2e service util functions into service_util.go and cleans up #39313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-github-robot
added
size/XXL
k8s-github-robot
added
the
needs-rebase
|
Looks ok to me -- this is just moving a bunch of code, right? |
|
LGTM |
|
need to rebase |
MrHohn
force-pushed
the
e2e-service-util
branch
from
d8d3e4d
to
e5944f5
Compare
k8s-github-robot
removed
the
needs-rebase
|
@bowei Yes, basically moving codes into service_util.go and capitalizing public functions. Rebased, thanks for reviewing! Wait for the tests to pass. |
freehan
added
lgtm
|
Automatic merge from submit-queue (batch tested with PRs 39280, 37350, 39389, 39390, 39313) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically moves codes into a central place for service util functions.
Some other codes are touched mostly only due to this migration. Also put a bunch of network reachability utils functions into network_utils.go. They seem somehow redundant, may consider combine they later.
@bowei @freehan