-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the deprecated --reconcile-cidr flag from kubelet #39322
Remove the deprecated --reconcile-cidr flag from kubelet #39322
Conversation
f69d2bd
to
359e735
Compare
Jenkins Bazel Build failed for commit 359e735c47ae1b4e602791b105fa80dd83d234a7. Full PR test history. The magic incantation to run this job again is |
Jenkins GKE smoke e2e failed for commit 359e735c47ae1b4e602791b105fa80dd83d234a7. Full PR test history. The magic incantation to run this job again is |
Jenkins GCI GKE smoke e2e failed for commit 359e735c47ae1b4e602791b105fa80dd83d234a7. Full PR test history. The magic incantation to run this job again is |
Jenkins GCE etcd3 e2e failed for commit 359e735c47ae1b4e602791b105fa80dd83d234a7. Full PR test history. The magic incantation to run this job again is |
Jenkins Kubemark GCE e2e failed for commit 359e735c47ae1b4e602791b105fa80dd83d234a7. Full PR test history. The magic incantation to run this job again is |
Jenkins GCE e2e failed for commit 359e735c47ae1b4e602791b105fa80dd83d234a7. Full PR test history. The magic incantation to run this job again is |
Jenkins CRI GCE Node e2e failed for commit 359e735c47ae1b4e602791b105fa80dd83d234a7. Full PR test history. The magic incantation to run this job again is |
Jenkins GCE Node e2e failed for commit 359e735c47ae1b4e602791b105fa80dd83d234a7. Full PR test history. The magic incantation to run this job again is |
Jenkins GCI GCE e2e failed for commit 359e735c47ae1b4e602791b105fa80dd83d234a7. Full PR test history. The magic incantation to run this job again is |
Jenkins unit/integration failed for commit 359e735c47ae1b4e602791b105fa80dd83d234a7. Full PR test history. The magic incantation to run this job again is |
Jenkins verification failed for commit 359e735c47ae1b4e602791b105fa80dd83d234a7. Full PR test history. The magic incantation to run this job again is |
359e735
to
4043229
Compare
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue (batch tested with PRs 39351, 39322) |
Do we have a policy for how long flags should stick around? If not, I'd suggest we should keep the flag as deprecated for 2 releases in future, not least because in this case the version that deprecated it was released only a few weeks ago. |
The deprecation policy was merged, but jekyll is unhappy with some of the
markdown (sigh), even though github itself renders just fine.
I boldly assumed that since this was commented as "remove in 1.6" it had
already been followed (I can't keep track of all the flags at this point :).
https://github.com/kubernetes/kubernetes.github.io/blob/master/docs/deprecation-policy.md
says 6 months or 1 release, whichever is longer
…On Tue, Jan 3, 2017 at 9:27 AM, Justin Santa Barbara < ***@***.***> wrote:
Do we have a policy for how long flags should stick around? If not, I'd
suggest we should keep the flag as deprecated for 2 releases in future, not
least because in this case the version that deprecated it was released only
a few weeks ago.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#39322 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFVgVGDIor9bNXastTi3UtsQBYG7_rJEks5rOoUSgaJpZM4LYMNx>
.
|
Yeah, this broke us due to the fact that it was deprecated too quickly. +1 for 6 months... |
What this PR does / why we need it:
Removes the
--reconcile-cidr
flag that has been deprecated since v1.5Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note:
@thockin