Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log error modification #39361

Merged
merged 1 commit into from
Jan 4, 2017
Merged

Log error modification #39361

merged 1 commit into from
Jan 4, 2017

Conversation

zdj6373
Copy link
Contributor

@zdj6373 zdj6373 commented Jan 3, 2017

controller_utils.go: Log content is wrong, modify

@k8s-ci-robot
Copy link
Contributor

Hi @zdj6373. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 3, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Jan 3, 2017
@mikedanese
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2017
@mikedanese mikedanese added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jan 3, 2017
@zmerlynn
Copy link
Member

zmerlynn commented Jan 3, 2017

@k8s-bot aws e2e test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 39001, 39104, 35978, 39361, 39273)

@k8s-github-robot k8s-github-robot merged commit 8554599 into kubernetes:master Jan 4, 2017
@zdj6373 zdj6373 deleted the util-log branch January 4, 2017 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mikedanese mikedanese

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zdj6373 @k8s-ci-robot @k8s-reviewable @mikedanese @zmerlynn @k8s-github-robot