Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in NC #41073

Merged
merged 1 commit into from
Feb 7, 2017
Merged

Fix bug in NC #41073

merged 1 commit into from
Feb 7, 2017

Conversation

gmarek
Copy link
Contributor

@gmarek gmarek commented Feb 7, 2017

It was introduced by #40385 cc @ncdc

@gmarek gmarek added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 7, 2017
@gmarek gmarek added this to the 1.6 milestone Feb 7, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 7, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@ncdc
Copy link
Member

ncdc commented Feb 7, 2017

@gmarek sorry about that and thanks for catching!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2017
@wojtek-t
Copy link
Member

wojtek-t commented Feb 7, 2017

/approve

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 7, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: gmarek, wojtek-t

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2017
@ncdc
Copy link
Member

ncdc commented Feb 7, 2017

@k8s-bot node e2e test this

@ncdc
Copy link
Member

ncdc commented Feb 7, 2017

@k8s-bot gce etcd3 e2e test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 41064, 41090, 41068, 41073, 40882)

@k8s-github-robot k8s-github-robot merged commit 461514f into kubernetes:master Feb 7, 2017
@calebamiles calebamiles modified the milestones: v1.6, 1.6 Feb 13, 2017
@gmarek gmarek deleted the nc-bug branch February 21, 2017 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants