-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
give nodes update/delete permissions #41345
give nodes update/delete permissions #41345
Conversation
[APPROVALNOTIFIER] This PR is APPROVED The following people have approved this PR: liggitt Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
If you're ok with, then I'm ok with it. /lgtm |
Same sentiment as @deads2k :) |
Automatic merge from submit-queue |
delete permission is logically paired with create permission (and is used during self-registration scenarios when a node has been restarted and an existing node object has a mismatched externalID)
we already need to scope update nodes/status permission to only let a node update itself, and we would scope these at the same time.
fixes #41224