Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make scheduler_perf warn rather then fail if scheduling rate is betwe… #41494

Merged
merged 1 commit into from
Feb 17, 2017
Merged

Make scheduler_perf warn rather then fail if scheduling rate is betwe… #41494

merged 1 commit into from
Feb 17, 2017

Conversation

jayunit100
Copy link
Member

What this PR does / why we need it

Fix scheduler per bench tests so they pass even if there is a cold interval .

Special notes for your reviewer:

This wont effect CI, as this bench test is run manually by devs.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 15, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Feb 15, 2017
@jayunit100 jayunit100 force-pushed the sched_per_warn branch 4 times, most recently from 2896e71 to f2f4322 Compare February 15, 2017 22:58
@gmarek gmarek assigned gmarek and unassigned fejta Feb 16, 2017
gmarek
gmarek reviewed Feb 16, 2017
View reviewed changes
test/integration/scheduler_perf/scheduler_test.go Outdated
} else {
fmt.Printf("Minimal observed throughput for 3k pod test: %v\n", min)
fmt.Printf("Minimal observed throughput for 3K pod test: %v\n", min)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why capital K?

@gmarek
Copy link
Contributor

gmarek commented Feb 16, 2017

One nit + gofmt issues.

@jayunit100
Copy link
Member Author

ping @gmarek ready to go on this one? thanks for the review !~

@gmarek
Copy link
Contributor

gmarek commented Feb 16, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2017
@gmarek gmarek added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Feb 16, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: gmarek, jayunit100

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2017
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 41517, 41494, 41163)

@k8s-github-robot k8s-github-robot merged commit b625fea into kubernetes:master Feb 17, 2017
@k8s-ci-robot
Copy link
Contributor

@jayunit100: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins unit/integration 11ab4ba link @k8s-bot unit test this
Jenkins Kubemark GCE e2e 11ab4ba link @k8s-bot kubemark e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmarek gmarek gmarek left review comments

Assignees

@gmarek gmarek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jayunit100 @k8s-reviewable @gmarek @k8s-github-robot @k8s-ci-robot @fejta