-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kubectl in addon-manager to use HPA in autoscaling/v1 #41587
Update kubectl in addon-manager to use HPA in autoscaling/v1 #41587
Conversation
Don't know this super well, but looks reasonable. /lgtm |
@@ -12,8 +12,7 @@ spec: | |||
# When updating version also bump it in: | |||
# - cluster/images/hyperkube/static-pods/addon-manager-singlenode.json | |||
# - cluster/images/hyperkube/static-pods/addon-manager-multinode.json | |||
# - cluster/gce/coreos/kube-manifests/kube-addon-manager.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The path for kube-addon-manager.yaml
was actually updated to
cluster/saltbase/salt/kube-addons/kube-addon-manager.yaml
test/kubemark/resources/manifests/kube-addon-manager.yaml
My personal thinking is that we can probably remove all of the comments here
# When updating version also bump it in:
# - cluster/images/hyperkube/static-pods/addon-manager-singlenode.json
# - cluster/images/hyperkube/static-pods/addon-manager-multinode.json
# - cluster/gce/coreos/kube-manifests/kube-addon-manager.yaml
As the comments is difficult to maintain and also I think that most developer can simply grep
to get and replace all needed places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gyliu513 Removed the pointers in test/kubemark/resources/manifests/kube-addon-manager.yaml
and updated the references in cluster/saltbase/salt/kube-addons/kube-addon-manager.yaml
, which is expected to be the entry point when bumping up addon-manager.
Yeah these comments are messy, but it would be better to have it. At least people will know they may need to grep
. I hope we will later have pre-submit checks to ensure files are in-synced (by putting specific lint comments in codes).
@jbeda Sorry for the change after lgtm...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair enough, thanks.
…of extensions/v1beta1
a1f0563
to
2c8e898
Compare
@k8s-bot unit test this |
/lgtm |
/approve |
1 similar comment
/approve |
[APPROVALNOTIFIER] This PR is APPROVED The following people have approved this PR: MrHohn, gmarek, roberthbailey Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue (batch tested with PRs 41349, 41532, 41256, 41587, 41657) |
Addon-manager is broken since HPA objects were removed from extensions api group.
Came across the logs from the latest addon-manager on Jenkins:
And notice this commit (f66679a) came in two weeks ago, which removed HorizontalPodAutoscaler from extensions/v1beta1.
Addon-manager is now partially functioning that it could successfully create and update addons, but will fail to prune objects, which means upgrade tests may mostly fail.
Pushed another version of addon-manager with kubectl v1.6.0-alpha.2 (release 2 days ago) for fixing, including below images:
@mikedanese
cc @wojtek-t @shyamjvs