Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dns #41657

Merged
merged 2 commits into from
Feb 22, 2017
Merged

Update dns #41657

merged 2 commits into from
Feb 22, 2017

Conversation

bowei
Copy link
Member

@bowei bowei commented Feb 17, 2017 

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 17, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Feb 17, 2017
@bowei bowei mentioned this pull request Feb 17, 2017
Closed
@bowei
Copy link
Member Author

bowei commented Feb 17, 2017

@k8s-bot gci gke e2e test this

@bowei
Copy link
Member Author

bowei commented Feb 17, 2017

@k8s-bot non-cri node e2e test this

@pires
Copy link
Contributor

pires commented Feb 19, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2017
@bowei
Copy link
Member Author

bowei commented Feb 20, 2017

@pires -- /approve is needed now ...

@bowei
Copy link
Member Author

bowei commented Feb 20, 2017

/approve

@bowei
Copy link
Member Author

bowei commented Feb 21, 2017

@mikedanese @luxas @errordeveloper looks like this needs an approver

@luxas
Copy link
Member

luxas commented Feb 21, 2017

/approve

Thanks for updating kubeadm as well!

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: bowei, luxas

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 41349, 41532, 41256, 41587, 41657)

@k8s-github-robot k8s-github-robot merged commit 44aa167 into kubernetes:master Feb 22, 2017
@luxas luxas mentioned this pull request Feb 22, 2017
Closed
@bowei bowei deleted the update-dns branch March 6, 2017 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pires pires pires approved these changes

Assignees

@pires pires

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bowei @k8s-reviewable @pires @luxas @k8s-github-robot @k8s-ci-robot