-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kubemark hollow-npd. #41703
Fix kubemark hollow-npd. #41703
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED The following people have approved this PR: Random-Liu Needs approval from an approver in each of these OWNERS Files: We suggest the following people: |
@k8s-bot kops aws e2e test this |
I don't think we can get owner approvals tonight. @Random-Liu explained the change to me, and it seems reasonable and appears to fix the problem. I'll merge on green to unblock the submit queue. |
@foxish Thanks for taking care of this! |
Wow thanks! I was also staring at it and has no clue at all 😝 |
I hope this fixes it! All credit to Lantao for figuring this out late at
night on a weekend. Cheers. Thanks!
…On Feb 18, 2017 10:41 PM, "Sen Lu" ***@***.***> wrote:
Wow thanks! I was also staring at it and has no clue at all 😝
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#41703 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA3U572AAU5RMoFvwOzj3NL0pToIVQSEks5rd-QwgaJpZM4MFXFB>
.
|
In NPD v0.3.0-alpha.1, node problem detector will error out if the specified log file doesn't exist.
Previously, kubemark uses a non-exist log file
/log/faillog
to make npd idle, as hollow-npd. However, it won't work with new npd.This PR changed the log path to
/dev/null
, so that npd won't be able to read anything, and/dev/null
will definitely exist in the container.I started kubemark cluster with this change myself, and it works properly now.
@foxish @shyamjvs @wojtek-t