Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #41746 #41784

Merged
merged 1 commit into from
Feb 23, 2017
Merged

fix issue #41746 #41784

merged 1 commit into from
Feb 23, 2017

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented Feb 21, 2017

What this PR does / why we need it:

Which issue this PR fixes : fixes #41746

Special notes for your reviewer:

cc @feiskyer

@k8s-ci-robot
Copy link
Contributor

Hi @dixudx. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 21, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Feb 21, 2017
@feiskyer
Copy link
Member

@k8s-bot ok to test

@resouer resouer added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Feb 21, 2017
@feiskyer
Copy link
Member

Thanks. LGTM

@feiskyer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2017
@feiskyer
Copy link
Member

cc @yujuhong @Random-Liu for approval.

@yujuhong
Copy link
Contributor

/approve

Thanks for the fix!

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: dixudx, yujuhong

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2017
@yujuhong yujuhong assigned yujuhong and unassigned sjpotter Feb 21, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 41146, 41486, 41482, 41538, 41784)

@k8s-github-robot k8s-github-robot merged commit c36eee2 into kubernetes:master Feb 23, 2017
@dixudx dixudx deleted the fix_issue_41746 branch September 9, 2017 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockertools unit test failed on OSX
8 participants