Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed duplicated 'default' in kubelet's help message #42331

Merged
merged 1 commit into from
May 2, 2017
Merged

Removed duplicated 'default' in kubelet's help message #42331

merged 1 commit into from
May 2, 2017

Conversation

k82cn
Copy link
Member

@k82cn k82cn commented Mar 1, 2017 

None

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 1, 2017
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Mar 1, 2017
@k82cn
Copy link
Member Author

k82cn commented Mar 2, 2017

@k8s-bot kops aws e2e test this

@k82cn
Copy link
Member Author

k82cn commented Mar 2, 2017

Example of duplicated default message in help:

      --host-network-sources stringSlice                        Comma-separated list of sources from which the Kubelet allows pods to use of host network. [default="*"] (default [*])

@k8s-reviewable
Copy link

This change is Reviewable

@dchen1107
Copy link
Member

dchen1107 commented Mar 13, 2017 •
edited

/lgtm
and
/approve

@dchen1107
Copy link
Member

Thanks for helping us clean up the code base.

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2017
@k82cn
Copy link
Member Author

k82cn commented Mar 27, 2017

/lgtm

echo dchen1107's lgtm.

@k8s-ci-robot
Copy link
Contributor

@k82cn: you cannot LGTM your own PR.

In response to this comment:

/lgtm

echo dchen1107's lgtm.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, k82cn

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k82cn
Copy link
Member Author

k82cn commented Mar 27, 2017

ping @dchen1107 for lgtm label; seems it's ignore by robot :)

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 7, 2017
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 9, 2017
@k82cn
Copy link
Member Author

k82cn commented Apr 9, 2017

@k8s-bot gce etcd3 e2e test this

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 29, 2017
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 30, 2017
@k82cn
Copy link
Member Author

k82cn commented Apr 30, 2017

@k8s-bot unit test this

@k82cn
Copy link
Member Author

k82cn commented Apr 30, 2017

@dchen1107 , ping for lgtm label :).

@dchen1107 dchen1107 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit b976481 into kubernetes:master May 2, 2017
@k82cn k82cn deleted the rm_dup_default branch May 2, 2017 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@k82cn @k8s-reviewable @dchen1107 @k8s-ci-robot @k8s-github-robot