Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enque DaemonSet sync when node taints changed #42414

Merged
merged 1 commit into from
Mar 4, 2017
Merged

Enque DaemonSet sync when node taints changed #42414

merged 1 commit into from
Mar 4, 2017

Conversation

lukaszo
Copy link
Contributor

@lukaszo lukaszo commented Mar 2, 2017

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 2, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Mar 2, 2017
@0xmichalis 0xmichalis added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Mar 2, 2017
@0xmichalis 0xmichalis added this to the v1.6 milestone Mar 2, 2017
@0xmichalis 0xmichalis added the kind/bug Categorizes issue or PR as related to a bug. label Mar 2, 2017
@0xmichalis
Copy link
Contributor

@lukaszo add a unit test for updateNode. You will need to fake dsc.enqueueDaemonSet(ds) similar to what I did for the recreate deployment test in #39794

@lukaszo
Copy link
Contributor Author

lukaszo commented Mar 2, 2017

@Kargakis adding

@mdshuai
Copy link

mdshuai commented Mar 2, 2017

Thanks fix it.

@lukaszo
Copy link
Contributor Author

lukaszo commented Mar 2, 2017

Added unit test

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 2, 2017
@mikedanese
Copy link
Member

/approve

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2017
@0xmichalis
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: kargakis, lukaszo, mikedanese

Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@lukaszo: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins GCI GKE smoke e2e 5dbb8e0 link @k8s-bot gci gke e2e test this
Jenkins GKE smoke e2e 5dbb8e0 link @k8s-bot cvm gke e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lukaszo
Copy link
Contributor Author

lukaszo commented Mar 3, 2017

It's blocked by flake #42484 :/

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 42456, 42457, 42414, 42480, 42370)

@k8s-github-robot k8s-github-robot merged commit 204ffda into kubernetes:master Mar 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants