Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #41667 #42200 upstream release 1.5 #42423

Merged
merged 3 commits into from Mar 9, 2017
Merged

Automated cherry pick of #41667 #42200 upstream release 1.5 #42423

merged 3 commits into from Mar 9, 2017

Conversation

mikedanese
Copy link
Member

Probably broken since some stuff has changed.

@cjcullen

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 2, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2017
@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Mar 2, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 2, 2017 •
edited

@mikedanese: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins GKE smoke e2e 8b8b1ad link @k8s-bot cvm gke e2e test this
Jenkins GCI GKE smoke e2e 8b8b1ad link @k8s-bot gci gke e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zmerlynn zmerlynn added this to the v1.5 milestone Mar 7, 2017
@zmerlynn
Copy link
Member

zmerlynn commented Mar 7, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: mikedanese, zmerlynn

Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@mikedanese mikedanese added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Mar 8, 2017
@mwielgus mwielgus added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Mar 8, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 0df1de9 into kubernetes:release-1.5 Mar 9, 2017
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.5" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@mikedanese mikedanese deleted the automated-cherry-pick-of-#41667-#42200-upstream-release-1.5 branch March 9, 2017 17:34
@mikedanese mikedanese mentioned this pull request Mar 21, 2017
Closed
@liggitt liggitt mentioned this pull request Mar 27, 2017
Merged
mintzhao pushed a commit to mintzhao/kubernetes that referenced this pull request Jun 1, 2017
Merge pull request kubernetes#42423 from mikedanese/automated-cherry-…
5f70535 
…pick-of-#41667-kubernetes#42200-upstream-release-1.5

Automatic merge from submit-queue

Automated cherry pick of kubernetes#41667 kubernetes#42200 upstream release 1.5

Probably broken since some stuff has changed.

@cjcullen
@k8s-ci-robot k8s-ci-robot mentioned this pull request Sep 11, 2020
Closed
@k8s-ci-robot k8s-ci-robot mentioned this pull request Sep 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zmerlynn zmerlynn

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mikedanese @k8s-reviewable @k8s-ci-robot @zmerlynn @k8s-github-robot @k8s-cherrypick-bot @mwielgus