federation: avoid double core group registration #42722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
size/L
|
This change is |
sttts
added
release-note-none
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Is this for 1.6 or later? |
|
@nikhiljindal I have not investigated whether there are any consequences like inconcistencies. Maybe the import order is hiding problems. wdyt? |
k8s-github-robot
added
the
needs-rebase
|
LGTM, thanks! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, nikhiljindal, sttts
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
@k8s-bot gce etcd3 e2e test this |
|
Needs rebase. |
sttts
force-pushed
the
sttts-federation-core-group
branch
from
a84b8bd
to
dcb50aa
Compare
k8s-github-robot
removed
lgtm
Done. |
sttts
added
the
lgtm
|
Automatic merge from submit-queue (batch tested with PRs 43870, 30302, 42722, 43736) |
|
@sttts PR needs rebase |
k8s-github-robot
added
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The federation apiserver installed its custom core group into the global
pkg/apiregistry, leading to double registration. Luckily (or maybe unfortunately) we did not fail hard in this case, but the init funcs just ignored the error.This PR creates an extra apigroup registry based on the already existing federation
core.Scheme. This decouples the two core groups (which happen to co-exist in hyperkube).