Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some typo #42772

Merged
merged 1 commit into from
Apr 5, 2017
Merged

fix some typo #42772

merged 1 commit into from
Apr 5, 2017

Conversation

timchenxiaoyu
Copy link
Contributor

fix some typo

Release note:

@k8s-ci-robot
Copy link
Contributor

Hi @timchenxiaoyu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 9, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Mar 9, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@brendandburns
Copy link
Contributor

/lgtm

/release-note-none

LGTM + release-note-none from the bulk LGTM tool

@brendandburns brendandburns self-assigned this Mar 9, 2017
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: brendandburns, timchenxiaoyu

Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @timstclair
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2017
@brendandburns
Copy link
Contributor

@k8s-bot unit test this
@k8s-bot kops aws e2e test this
@k8s-bot gce etcd3 e2e test this

@brendandburns brendandburns added this to the v1.7 milestone Mar 13, 2017
@timchenxiaoyu
Copy link
Contributor Author

@k8s-bot kops aws e2e test this

@k8s-ci-robot
Copy link
Contributor

@timchenxiaoyu: you can't request testing unless you are a kubernetes member.

In response to this comment:

@k8s-bot kops aws e2e test this

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@grodrigues3 grodrigues3 added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 5, 2017
@grodrigues3
Copy link
Contributor

@k8s-bot ok to test

@grodrigues3
Copy link
Contributor

@k8s-bot kops aws e2e test this

@grodrigues3 grodrigues3 removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 5, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 44097, 42772, 43880, 44031, 44066)

@k8s-github-robot k8s-github-robot merged commit 62c7c66 into kubernetes:master Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brendandburns brendandburns

@vishh vishh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@timchenxiaoyu @k8s-ci-robot @k8s-reviewable @brendandburns @k8s-github-robot @grodrigues3 @vishh