-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update influxdb dependency to v1.1.1 and change client to v2 #42930
update influxdb dependency to v1.1.1 and change client to v2 #42930
Conversation
Hi @KarolKraskiewicz. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR is a follow up to #41925 (comment) |
@k8s-bot ok to test |
This needs to be fixed
Did you follow this guide: https://github.com/kubernetes/community/blob/master/contributors/devel/godep.md? |
@piosz Yes, I followed the guide. I will see how I can get BUILD regenerated and update PR. |
Ok, it seems I need to run |
ok, it should fix bazel build |
bf31baf
to
b6edff5
Compare
@k8s-bot verify test this |
/lgtm |
@ethernetdan low risk change bump deps used in e2e tests |
@wojtek-t can you please approve? |
ping @wojtek-t |
@k8s-bot kops aws e2e test this |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KarolKraskiewicz, piosz, wojtek-t
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue |
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
cc @piosz
./hack/godep-save.sh
so I left previous version.Not sure how to trigger regeneration of this file.
tests/e2e/monitoring.go
seem to be passing without changes, even after changing version of the client.Release note: