Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update influxdb dependency to v1.1.1 and change client to v2 #42930

Merged

Conversation

KarolKraskiewicz
Copy link
Contributor

What this PR does / why we need it:

  1. it updates version of influxdb libraries used by tests to v1.1.1 to match version used by grafana
  2. it switches influxdb client to v2 to address the fact that v1 is being depricated

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:
cc @piosz

  1. vendor/BUILD didn't get regenerated after executing ./hack/godep-save.sh so I left previous version.
    Not sure how to trigger regeneration of this file.
  2. tests/e2e/monitoring.go seem to be passing without changes, even after changing version of the client.

Release note:

@k8s-ci-robot
Copy link
Contributor

Hi @KarolKraskiewicz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 11, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels Mar 11, 2017
@KarolKraskiewicz
Copy link
Contributor Author

This PR is a follow up to #41925 (comment)

@thockin
Copy link
Member

thockin commented Mar 13, 2017

@k8s-bot ok to test

@thockin thockin assigned piosz and unassigned thockin Mar 13, 2017
@piosz piosz added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Mar 13, 2017
@piosz
Copy link
Member

piosz commented Mar 13, 2017

This needs to be fixed

W0313 21:11:13.789]   (cd /root/.cache/bazel/_bazel_root/e9f728bbd90b3fba632eb31b20e1dacd/bazel-sandbox/7b09a824-174a-4b89-8660-c68f217276e0-76/execroot/kubernetes && \
W0313 21:11:13.793]   exec env - \
W0313 21:11:13.793]     GOARCH=amd64 \
W0313 21:11:13.793]     GOOS=linux \
W0313 21:11:13.794]   /root/.cache/bazel/_bazel_root/e9f728bbd90b3fba632eb31b20e1dacd/execroot/kubernetes/_bin/linux-sandbox @/root/.cache/bazel/_bazel_root/e9f728bbd90b3fba632eb31b20e1dacd/bazel-sandbox/7b09a824-174a-4b89-8660-c68f217276e0-76/linux-sandbox.params -- bazel-out/local-fastbuild/bin/vendor/bazel-out/local-fastbuild/bin/vendor/github.com/influxdata/influxdb/models.a.GoCompileFile.params).
I0313 21:11:13.903] k8s.io/kubernetes/vendor/github.com/influxdata/influxdb/models/points.go:294: undefined: parseIntBytes
I0313 21:11:13.904] k8s.io/kubernetes/vendor/github.com/influxdata/influxdb/models/points.go:831: undefined: parseIntBytes
I0313 21:11:13.904] k8s.io/kubernetes/vendor/github.com/influxdata/influxdb/models/points.go:838: undefined: parseFloatBytes
I0313 21:11:13.905] k8s.io/kubernetes/vendor/github.com/influxdata/influxdb/models/points.go:1502: undefined: NewInlineFNV64a
I0313 21:11:13.905] k8s.io/kubernetes/vendor/github.com/influxdata/influxdb/models/points.go:1695: undefined: parseIntBytes
I0313 21:11:13.905] k8s.io/kubernetes/vendor/github.com/influxdata/influxdb/models/points.go:1700: undefined: parseFloatBytes
I0313 21:11:13.906] k8s.io/kubernetes/vendor/github.com/influxdata/influxdb/models/points.go:1706: undefined: parseFloatBytes
I0313 21:11:13.906] k8s.io/kubernetes/vendor/github.com/influxdata/influxdb/models/points.go:1776: undefined: parseIntBytes
I0313 21:11:13.906] k8s.io/kubernetes/vendor/github.com/influxdata/influxdb/models/points.go:1784: undefined: parseBoolBytes
I0313 21:11:13.906] k8s.io/kubernetes/vendor/github.com/influxdata/influxdb/models/points.go:1792: undefined: parseFloatBytes
I0313 21:11:13.907] k8s.io/kubernetes/vendor/github.com/influxdata/influxdb/models/points.go:1792: too many errors
W0313 21:11:14.020] ____[5,920 / 7,978] GoCompile plugin/pkg/auth/authorizer/rbac/bootstrappolicy/go_default_test.a

Did you follow this guide: https://github.com/kubernetes/community/blob/master/contributors/devel/godep.md?

@piosz piosz added this to the v1.6 milestone Mar 13, 2017
@KarolKraskiewicz
Copy link
Contributor Author

@piosz Yes, I followed the guide.
As mentioned above the problem was that vendor/BUILD didn't get regenerated, so I just left the old one (so the new types are not recognized by bazel). I somehow did not realize Bazel builds are now officially supported.

I will see how I can get BUILD regenerated and update PR.

@KarolKraskiewicz
Copy link
Contributor Author

Ok, it seems I need to run ./hack/update-bazel.sh on the project. I will take a look at it tomorrow.

@KarolKraskiewicz
Copy link
Contributor Author

ok, it should fix bazel build

@piosz
Copy link
Member

piosz commented Mar 15, 2017

@k8s-bot verify test this

@piosz
Copy link
Member

piosz commented Mar 15, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2017
@piosz
Copy link
Member

piosz commented Mar 15, 2017

@ethernetdan low risk change bump deps used in e2e tests

@piosz
Copy link
Member

piosz commented Mar 16, 2017

@wojtek-t can you please approve?

@piosz
Copy link
Member

piosz commented Mar 22, 2017

ping @wojtek-t

@piosz
Copy link
Member

piosz commented Mar 22, 2017

@k8s-bot kops aws e2e test this

@wojtek-t
Copy link
Member

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KarolKraskiewicz, piosz, wojtek-t

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 9dae6a7 into kubernetes:master Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants