New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Cluster Autoscaler entrypoint #42988
Update Cluster Autoscaler entrypoint #42988
Conversation
Hi @MaciekPytel. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED The following people have approved this PR: MaciekPytel, eparis, mwielgus Needs approval from an approver in each of these OWNERS Files:
We suggest the following people: |
@k8s-bot gce etcd3 e2e test this |
@k8s-bot kops aws e2e test this |
"env": [ | ||
{ | ||
"name": "LOG_OUTPUT", | ||
"value": "/var/log/cluster-autoscaler.log" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious, can't this fill the container disk? What happens if this fills the disk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is mounted from the machine disk. I guess that there is some log rotation policy for /var/logs on the master (but can doublecheck).
What this PR does / why we need it:
Update Cluster Autoscaler manifest file to use new shell wrapper instead of directly calling CA binary (the wrapper is already included in current CA image).
Add params to improve logging.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: