Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dumb typo in kubeadm instructions #43022

Merged
merged 1 commit into from Mar 14, 2017
Merged

Dumb typo in kubeadm instructions #43022

merged 1 commit into from Mar 14, 2017

Conversation

jbeda
Copy link
Contributor

@jbeda jbeda commented Mar 13, 2017

I typo'd chown as chmod in kubeadm instructions. Ugh.

NONE

@jbeda
Dumb typo in kubeadm instructions
505464d 
Signed-off-by: Joe Beda <joe.github@bedafamily.com>
@jbeda jbeda added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 13, 2017
@jbeda jbeda added this to the v1.6 milestone Mar 13, 2017
@jbeda jbeda requested a review from luxas March 13, 2017 21:51
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 13, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 13, 2017
@k8s-reviewable
Copy link

This change is Reviewable

dmmcquay
dmmcquay approved these changes Mar 13, 2017
View reviewed changes
Copy link
Contributor

@dmmcquay dmmcquay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jbeda jbeda assigned dmmcquay and unassigned luxas Mar 13, 2017
@dmmcquay
Copy link
Contributor

/lgtm

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: dmmcquay, jbeda

Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @errordeveloper
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@jbeda
Copy link
Contributor Author

jbeda commented Mar 13, 2017

@k8s-bot unit test this

@jbeda jbeda added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2017
luxas
luxas reviewed Mar 14, 2017
View reviewed changes
Copy link
Member

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we change the initial kubeadm init/join? warning as well to indicate the beta quality?

Idk what's beneficial here, because we'll still probably change the implementation in v1.7...

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@justinsb
Copy link
Member

@k8s-bot kops aws e2e test this

It's the route53 throttling we're dealing with right now; patch working its way through the queues concurrently.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 43022, 43078)

@k8s-github-robot k8s-github-robot merged commit c425b4e into kubernetes:master Mar 14, 2017
@k8s-ci-robot
Copy link
Contributor

@jbeda: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins GCE etcd3 e2e 505464d link @k8s-bot gce etcd3 e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luxas luxas luxas left review comments

@dmmcquay dmmcquay dmmcquay approved these changes

Assignees

@dmmcquay dmmcquay

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jbeda @k8s-reviewable @dmmcquay @k8s-github-robot @justinsb @k8s-ci-robot @luxas