Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #39311 #39768 #38547 #43095

Merged
merged 4 commits into from Mar 14, 2017
Merged

Automated cherry pick of #39311 #39768 #38547 #43095

merged 4 commits into from Mar 14, 2017

Conversation

jessfraz
Copy link
Contributor

Cherry pick of #39311 #39768 #38547 on release-1.4.

#39311: Check if pathExists before performing Unmount
#39768: Check if path exists before performing unmount
#38547: Use common unmount util func for TearDownAt()

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 14, 2017
@jessfraz jessfraz mentioned this pull request Mar 14, 2017
Closed
@jessfraz jessfraz added this to the v1.4 milestone Mar 14, 2017
@jessfraz jessfraz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate labels Mar 14, 2017
@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Mar 14, 2017
@jessfraz jessfraz added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Mar 14, 2017
@jessfraz
fix build errors
6b4957d 
Signed-off-by: Jess Frazelle <acidburn@google.com>
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jessfraz
We suggest the following additional approvers: @Kargakis, @thockin

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@jessfraz jessfraz added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 14, 2017
@jessfraz
Copy link
Contributor Author

merging since all green

@jessfraz jessfraz merged commit 96ddb18 into kubernetes:release-1.4 Mar 14, 2017
@jessfraz jessfraz deleted the automated-cherry-pick-of-#39311-#39768-#38547-origin-release-1.4 branch March 14, 2017 22:35
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pmorie pmorie

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jessfraz @k8s-reviewable @k8s-github-robot @k8s-cherrypick-bot @pmorie @k8s-ci-robot @rkouj