-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #38330 #43190
Automated cherry pick of #38330 #43190
Conversation
Hi @zhouhaibing089. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The 'parent' PR of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement. (release-note-experimental must be explicit for cherry-picks) |
@k8s-bot ok to test |
/lgtm |
@mwielgus could you approve the cherry-pick? |
Removing label |
@k8s-bot unit test this |
UT build failed.. need some change.. |
fdc99de
to
3e7475d
Compare
@zhouhaibing089 can you highlight what did you change? |
@caesarxuchao the change I made: |
/lgtm |
@mwielgus could you approve the cherrypick? Thanks. |
cherrypick approved. |
cc @lavalamp could you approve? |
Is this needed for anything other than kubeadm? We won't release an update to kubeadm off the 1.5 stream |
@liggitt it also resolves the objection deletion in federation.. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: caesarxuchao, lavalamp, zhouhaibing089
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue |
Commit found in the "release-1.5" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
Cherry pick of #38330 on release-1.5.
#38330: let DirectEncoder take a hint of what gvk to set during its