Use storage.k8s.io/v1 in tests instead of v1beta1 #43296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsafrane
added
the
sig/storage
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
size/L
|
This change is |
|
Thanks @jsafrane. Looks good. |
k8s-github-robot
added
approved
|
/assign @divyenpatel |
k8s-github-robot
added
the
approved
msau42
reviewed
Mar 17, 2017
| }) | ||
| framework.KubeDescribe("DynamicProvisioner", func() { | ||
| It("should create and delete persistent volumes [Slow] [Volume]", func() { | ||
| framework.SkipUnlessProviderIs("openstack", "gce", "aws", "gke") |
There was a problem hiding this comment.
@divyenpatel You should add vsphere back to all these tests once your CI environment is updated.
There was a problem hiding this comment.
@msau42 Yes sure.
cc: @BaluDontu @tusharnt
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ixdy, jsafrane, msau42
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is trimmed version of #42477 and contains only tests of the new storage API. Together with #43285 it passes all dynamic provisioning tests on my GCE.
I did not change vsphere_utils.go and vsphere_volume_diskformat.go as @divyenpatel runs master vsphere tests with Kubernetes 1.5 - @divyenpatel, did I get it right?
@kubernetes/sig-storage-pr-reviews, @msau42, @ethernetdan