-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubectl/cmd: remove a bunch of unused parameters #43297
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @mvdan. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Boy those are a lot of comments. Signed it. |
The change itself, lgtm, @mvdan mind updating your PR? |
@soltysh done |
/approve |
/lgtm |
@k8s-bot ok to test |
Rebased again and fixed the test builds. |
@mvdan you are failing bazel build, still. |
Found with github.com/mvdan/unparam.
@soltysh apologies, finally done |
/lgtm |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deads2k, mvdan, soltysh
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
bump - needs an additional approver? |
@nikhiljindal can you approve the federation part, it's pretty simple change. |
bump @nikhiljindal |
Automatic merge from submit-queue |
Found with github.com/mvdan/unparam.
Release note: NONE