Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl/cmd: remove a bunch of unused parameters #43297

Merged
merged 1 commit into from
Apr 13, 2017
Merged

kubectl/cmd: remove a bunch of unused parameters #43297

merged 1 commit into from
Apr 13, 2017

Conversation

mvdan
Copy link
Contributor

@mvdan mvdan commented Mar 17, 2017

Found with github.com/mvdan/unparam.

Release note: NONE

@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-label-needed labels Mar 17, 2017
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 17, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @mvdan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-reviewable
Copy link

This change is Reviewable

@mvdan
Copy link
Contributor Author

mvdan commented Mar 17, 2017

Boy those are a lot of comments. Signed it.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 17, 2017
@soltysh soltysh added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Mar 27, 2017
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 27, 2017
@soltysh
Copy link
Contributor

soltysh commented Mar 27, 2017

The change itself, lgtm, @mvdan mind updating your PR?

@soltysh soltysh added this to the v1.7 milestone Mar 27, 2017
@mvdan
Copy link
Contributor Author

mvdan commented Mar 27, 2017

@soltysh done

@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 27, 2017
@deads2k
Copy link
Contributor

deads2k commented Mar 27, 2017

/approve

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2017
@soltysh
Copy link
Contributor

soltysh commented Mar 28, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2017
@soltysh
Copy link
Contributor

soltysh commented Mar 28, 2017

@k8s-bot ok to test

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 3, 2017
@mvdan
Copy link
Contributor Author

mvdan commented Apr 3, 2017

Rebased again and fixed the test builds.

@soltysh
Copy link
Contributor

soltysh commented Apr 3, 2017

@mvdan you are failing bazel build, still.

Found with github.com/mvdan/unparam.
@k8s-github-robot k8s-github-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2017
@mvdan
Copy link
Contributor Author

mvdan commented Apr 5, 2017

@soltysh apologies, finally done

@soltysh
Copy link
Contributor

soltysh commented Apr 5, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deads2k, mvdan, soltysh
We suggest the following additional approver: @csbell

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@mvdan
Copy link
Contributor Author

mvdan commented Apr 7, 2017

bump - needs an additional approver?

@soltysh
Copy link
Contributor

soltysh commented Apr 7, 2017

@nikhiljindal can you approve the federation part, it's pretty simple change.

@deads2k deads2k added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2017
@mvdan
Copy link
Contributor Author

mvdan commented Apr 13, 2017

bump @nikhiljindal

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 19d7226 into kubernetes:master Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants