Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node failure tests for cluster autoscaler #43304

Merged
merged 2 commits into from
Apr 11, 2017
Merged

Node failure tests for cluster autoscaler #43304

merged 2 commits into from
Apr 11, 2017

Conversation

mwielgus
Copy link
Contributor

E2e tests checking whether CA is still working with a single broken node.

cc: @MaciekPytel @jszczepkowski @fgrzadkowski

@mwielgus mwielgus added release-note-none Denotes a PR that doesn't merit a release note. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. labels Mar 17, 2017
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 17, 2017
@k8s-github-robot k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 17, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@mwielgus
Copy link
Contributor Author

@k8s-bot verify test this

@MaciekPytel
Copy link
Contributor

\lgtm

@wojtek-t
Copy link
Member

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mwielgus, wojtek-t

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2017
@mwielgus mwielgus added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2017
@mwielgus
Copy link
Contributor Author

@k8s-bot verify test this

@mwielgus
Copy link
Contributor Author

mwielgus commented Mar 31, 2017 •
edited

@k8s-bot gce etcd3 e2e test this

@mwielgus
Copy link
Contributor Author

mwielgus commented Apr 3, 2017

@k8s-bot test this

jszczepkowski
jszczepkowski reviewed Apr 4, 2017
View reviewed changes
test/e2e/cluster_size_autoscaling.go Outdated
return nil
}
if len(nodes.Items) == 0 {
glog.Errorf("No nodes")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Errorf/Error

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 4, 2017
jszczepkowski
jszczepkowski reviewed Apr 4, 2017
View reviewed changes
test/e2e/cluster_size_autoscaling.go Outdated
"spec.unschedulable": "false",
}.AsSelector().String()})
if err != nil {
glog.Error("Failed to get node list: %v", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Error/Errorf

jszczepkowski
jszczepkowski reviewed Apr 4, 2017
View reviewed changes
test/e2e/cluster_size_autoscaling.go Outdated

It("should correctly scale down after a node is not needed [Feature:ClusterSizeAutoscalingScaleDown]", simpleScaleDownTest)

It("should increase cluster size if pending pods are small and one node is broken [Feature:ClusterSizeAutoscalingScaleUp]",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/increase/decrease

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sure increase is correct here (this is a scale up test)

@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 11, 2017
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2017
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2017
@mwielgus mwielgus added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2017
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 43304, 41427, 43490, 44352)

@k8s-github-robot k8s-github-robot merged commit 32d29d4 into kubernetes:master Apr 11, 2017
@k8s-ci-robot
Copy link
Contributor

@mwielgus: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins GCE etcd3 e2e c2f903b link @k8s-bot gce etcd3 e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaciekPytel MaciekPytel MaciekPytel left review comments

@jszczepkowski jszczepkowski jszczepkowski left review comments

Assignees

@jszczepkowski jszczepkowski

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mwielgus @k8s-reviewable @MaciekPytel @wojtek-t @k8s-github-robot @k8s-ci-robot @jszczepkowski