Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump Kubernetes packaged CNI to v0.5.1 #43536

Merged
merged 1 commit into from
Mar 22, 2017
Merged

bump Kubernetes packaged CNI to v0.5.1 #43536

merged 1 commit into from
Mar 22, 2017

Conversation

ethernetdan
Copy link
Contributor

Update version of packaged CNI to v0.5.1 in order as part of a fix for #43488.

Next steps compiling these versions and updating references to artifacts.

/cc @ixdy

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 22, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@ethernetdan
Copy link
Contributor Author

/cc @bowei @thockin

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Mar 22, 2017
@ixdy
Copy link
Member

ixdy commented Mar 22, 2017

/release-note-none
(because this doesn't change any specs)

@k8s-ci-robot
Copy link
Contributor

@ixdy: you can only set release notes if you are the author or an assignee.

In response to this comment:

/release-note-none
(because this doesn't change any specs)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ixdy
ixdy reviewed Mar 22, 2017
View reviewed changes
build/cni/Makefile
@@ -18,7 +18,7 @@
# [ARCH=amd64] [CNI_RELEASE=v0.3.0] make (build|push)

ARCH?=amd64
CNI_RELEASE?=07a8a28637e97b22eb8dfe710eeae1344f69d16e
CNI_RELEASE?=0799f5732f2a11b329d9e3d51b9c8f2e3759f2ff
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why we don't just use the tag, but I guess we can think about that at a later date.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@freehan do you know why we use a sha instead of a tag?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think at some point it was not tagged

@ixdy
Copy link
Member

ixdy commented Mar 22, 2017

/assign

@ixdy
Copy link
Member

ixdy commented Mar 22, 2017

/release-note-none
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed release-note-label-needed labels Mar 22, 2017
@ixdy ixdy added this to the v1.6 milestone Mar 22, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ethernetdan, ixdy

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2017
@luxas
Copy link
Member

luxas commented Mar 22, 2017

If we really do this, we should bump godeps and update the debs/rpms as well

@luxas
Copy link
Member

luxas commented Mar 22, 2017 •
edited

...and there's a lot of places where commit 07a8a28637e97b22eb8dfe710eeae1344f69d16e is referenced, we have to update those

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit db9fcb0 into kubernetes:master Mar 22, 2017
@ethernetdan
Copy link
Contributor Author

@luxas, after talking to @bowei it seems like that won't be necessary but he is double-checking now

@cmluciano
Copy link

I was working on the Godeps stuff, LMK if I should continue

@bowei
Copy link
Member

bowei commented Mar 22, 2017

I see the following differences between the vendor'ed 3.x.x and 5.x.x:

  • support for plugins on windows
  • NetConfList
  • Addition of the version field to the configuration

Both the NetConfList field and the Version field are marked omitIfEmpty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@ixdy ixdy ixdy left review comments

Assignees

@zmerlynn zmerlynn

@ixdy ixdy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@ethernetdan @k8s-reviewable @ixdy @k8s-ci-robot @k8s-github-robot @luxas @cmluciano @bowei @thockin @zmerlynn