Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kuberuntime: don't override the pod IP for pods using host network #43539

Merged
merged 1 commit into from
Mar 22, 2017

Conversation

yujuhong
Copy link
Contributor

This fixes the issue of not passing pod IP via downward API for host network pods.

@yujuhong yujuhong added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. labels Mar 22, 2017
@yujuhong yujuhong added this to the v1.6 milestone Mar 22, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 22, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 22, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@yujuhong
Copy link
Contributor Author

This fixes #43531

Tested manually.
Writing a unit test for this can be tricky. I'll file an issue for adding a node e2e test.

@Random-Liu
Copy link
Member

/lgtm

The logic is too confusing. We should clean this up at some point. :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2017
@yujuhong
Copy link
Contributor Author

The logic is too confusing. We should clean this up at some point. :)

I think we can push the responsibility of populating the ip to individual runtime packages (e.g., kuberuntime and rkt).

@dchen1107 dchen1107 self-assigned this Mar 22, 2017
@dchen1107
Copy link
Member

I remembered @freehan fixed this in old dockertool before. :-)

/lgtm

@jayunit100
Copy link
Member

So to clarify, the determineSandboxIp is the reason this took so long ?

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Random-Liu, dchen1107, yujuhong

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@yujuhong
Copy link
Contributor Author

So to clarify, the determineSandboxIp is the reason this took so long ?

Not sure what you meant. The bug is about not passing the pod ip to the container at creation time as environment variables. You'll still get the correct pod IP in the pod status.

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 43533, 43539)

@k8s-github-robot k8s-github-robot merged commit 7c24d1a into kubernetes:master Mar 22, 2017
@yujuhong yujuhong deleted the hostnet_ip branch May 19, 2017 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants