-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kuberuntime: don't override the pod IP for pods using host network #43539
Conversation
This fixes #43531 Tested manually. |
/lgtm The logic is too confusing. We should clean this up at some point. :) |
I think we can push the responsibility of populating the ip to individual runtime packages (e.g., |
I remembered @freehan fixed this in old dockertool before. :-) /lgtm |
So to clarify, the |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Random-Liu, dchen1107, yujuhong
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Not sure what you meant. The bug is about not passing the pod ip to the container at creation time as environment variables. You'll still get the correct pod IP in the pod status. |
Automatic merge from submit-queue (batch tested with PRs 43533, 43539) |
This fixes the issue of not passing pod IP via downward API for host network pods.