Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move e2e fromManifest funcs to manifest package #43637

Merged
merged 1 commit into from
Jun 24, 2017
Merged

Move e2e fromManifest funcs to manifest package #43637

merged 1 commit into from
Jun 24, 2017

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Mar 24, 2017

fixes #37007 again

The goal here is to remove e2e/framework's dependence on e2e/generated so that external projects can import e2e/framework without issue. I reorganize & try to make all the 'fromManifest' funcs consistent (to all use generated, return err) to prevent any reintroduction of generated into framework

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 24, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @wongma7. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Mar 24, 2017
@wongma7
Copy link
Contributor Author

wongma7 commented Mar 24, 2017

Darn, #43066 throws a wrench into this :) the non-statefulset parts & general idea of this PR can still be reviewed though...

@wongma7
Copy link
Contributor Author

wongma7 commented Mar 24, 2017

@foxish, here https://github.com/kubernetes/kubernetes/pull/43637/files#diff-20a9335743239e362032f5839bb81f98L106 why do we use RunKubectlOrDieInput? Wouldn't it be better to use the client and create the objects directly? To isolate the tests from kubectl

@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 24, 2017
@mikedanese
Copy link
Member

/approve

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2017
@foxish
Copy link
Contributor

foxish commented Mar 24, 2017

@wongma7 The change in that PR from fix from RunKubectlOrDie to RunKubectlOrDieInput were because the RunKubectlOrDie method was changing the cwd causing the manifests to not be found at all. It would be good to remove the dependency on kubectl entirely like you've done. I think it should still be possible, because all that #43066 changed is to read the YAML file and supply it to kubectl in stdin, rather than supplying the YAML file path to it.

@grodrigues3 grodrigues3 added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 5, 2017
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2017
@wongma7
Copy link
Contributor Author

wongma7 commented Apr 24, 2017

@erictune can you review or assign another reviewer, thanks! this is purely a mechanical & refactoring PR, no major additions.

@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2017
@wongma7
Copy link
Contributor Author

wongma7 commented May 3, 2017

@erictune ping please reassign

@spiffxp
Copy link
Member

spiffxp commented May 8, 2017

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 8, 2017
@spiffxp
Copy link
Member

spiffxp commented May 8, 2017

/cc @kubernetes/sig-testing-pr-reviews

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label May 8, 2017
@k8s-github-robot k8s-github-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2017
@wongma7
Copy link
Contributor Author

wongma7 commented May 8, 2017

Just added package to "hack/.linted_packages" to fix jenkins verification

@wongma7
Copy link
Contributor Author

wongma7 commented May 8, 2017

@k8s-bot gce etcd3 e2e test this

"Ginkgo timed out waiting for all parallel nodes to report back!"

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2017
@spxtr
Copy link
Contributor

spxtr commented Jun 9, 2017

/approve

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 9, 2017
@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 15, 2017
@spiffxp
Copy link
Member

spiffxp commented Jun 15, 2017

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2017
@wongma7
Copy link
Contributor Author

wongma7 commented Jun 16, 2017

@k8s-bot pull-kubernetes-federation-e2e-gce test this

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 21, 2017
@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 22, 2017
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 23, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 23, 2017 •
edited

@wongma7: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
Jenkins GCE etcd3 e2e de94e55 link @k8s-bot gce etcd3 e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@spiffxp
Copy link
Member

spiffxp commented Jun 24, 2017

/lgtm
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikedanese, spiffxp, spxtr, wongma7

Associated issue: 37007

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 156ff3a into kubernetes:master Jun 24, 2017
@a-robinson a-robinson mentioned this pull request Sep 20, 2017
Merged
a-robinson added a commit to a-robinson/kubernetes that referenced this pull request Sep 21, 2017
@a-robinson
Fix broken statefulset e2e test
284a7c6 
This was broken back in kubernetes#43637 when the logic in
`(*StatefulSetTester).CreateStatefulSet` switched from using
`generated.ReadOrDie` to read the entire service.yaml file and pass it
to kubectl to using `manifest.SvcFromManifest`, which assumes that the
file contains only a single service.

Fixes kubernetes#52750
k8s-github-robot pushed a commit that referenced this pull request Sep 25, 2017
Merge pull request #52806 from a-robinson/crdbtest
e9c964c 
Automatic merge from submit-queue (batch tested with PRs 51759, 53001, 52806). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>..

Fix broken statefulset e2e test

**What this PR does / why we need it**:

Fixes the CockroachDB statefulset e2e test.

This was broken back in #43637 when the logic in
`(*StatefulSetTester).CreateStatefulSet` switched from using
`generated.ReadOrDie` to read the entire service.yaml file and pass it
to kubectl to using `manifest.SvcFromManifest`, which assumes that the
file contains only a single service.

To fix the test, just remove the second service, which isn't needed to test the Statefulset functionality.

**Which issue this PR fixes**:

Fixes #52750

**Special notes for your reviewer**:

N/A

**Release note**:
```release-note
NONE
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spiffxp spiffxp

@erictune erictune

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test/e2e/framework cannot be imported into external projects
10 participants
@wongma7 @k8s-reviewable @k8s-ci-robot @mikedanese @foxish @spiffxp @spxtr @k8s-github-robot @grodrigues3 @erictune