Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve event msg for PV controller when using external provisioner #43679

Merged
merged 1 commit into from
Apr 10, 2017
Merged

Improve event msg for PV controller when using external provisioner #43679

merged 1 commit into from
Apr 10, 2017

Conversation

xingzhou
Copy link
Contributor

@xingzhou xingzhou commented Mar 27, 2017 •
edited

Improve event msg for PV controller when using external provisioner

Which issue this PR fixes *:
Fixed part of #42121

Special notes for your reviewer:
@jsafrane, as many of our users are confused by the original message, can we fix the message first and then consider how to control the count of the events?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 27, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @xingzhou. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Mar 27, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@jsafrane
Copy link
Member

jsafrane commented Apr 3, 2017

@k8s-bot ok to test

jsafrane
jsafrane reviewed Apr 3, 2017
View reviewed changes
pkg/controller/volume/persistentvolume/pv_controller.go Outdated
@@ -1250,7 +1250,7 @@ func (ctrl *PersistentVolumeController) provisionClaimOperation(claimObj interfa
// This means that an unknown provisioner is requested. Report an event
// and wait for the external provisioner
if storageClass != nil {
msg := fmt.Sprintf("cannot find provisioner %q, expecting that a volume for the claim is provisioned either manually or via external software", storageClass.Provisioner)
msg := fmt.Sprintf("waiting for external provisioner %q to provision a volume or creating a volume mannually for the claim", storageClass.Provisioner)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • typo mannually -> manually
  • in my (imperfect) English the sentence "waiting for external provisioner %q to provision a volume or creating a volume manually" means that Kubernetes is either "waiting for external provisioner" or "Kubernetes is creating a volume manually", which is not the case. Kubernetes is waiting for someone to create the volume, be it external provisioner or system admin.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsafrane, how about we changing the message to:
“waiting for a volume to be created, either by external provisioner %q or manually created by system administrator”

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that sounds much better

@rootfs
Copy link
Contributor

rootfs commented Apr 4, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Apr 4, 2017
@rootfs
Copy link
Contributor

rootfs commented Apr 4, 2017

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2017
@rootfs
Copy link
Contributor

rootfs commented Apr 4, 2017

/assign @jsafrane

@xingzhou
Improve event msg for PV controller when using external provisioner
5b29afb 
Improve event msg for PV controller when using external provisioner
@xingzhou
Copy link
Contributor Author

xingzhou commented Apr 5, 2017

@jsafrane, have updated the msg, PTAL, thanks!

@xingzhou
Copy link
Contributor Author

@jsafrane, have updated the message, any comments for the change?

@jsafrane
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2017
@jsafrane
Copy link
Member

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Apr 10, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, xingzhou

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2017
@jsafrane jsafrane removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Apr 10, 2017
@jsafrane
Copy link
Member

thanks for the PR!

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 3572e5c into kubernetes:master Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsafrane jsafrane jsafrane left review comments

Assignees

@jsafrane jsafrane

@rootfs rootfs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@xingzhou @k8s-ci-robot @k8s-reviewable @jsafrane @rootfs @k8s-github-robot