Extract ParseCIDR and modify attachDetachControllerName #43736
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-github-robot
added
size/M
| if err != nil { | ||
| glog.Warningf("Unsuccessful parsing of cluster CIDR %v: %v", s.ClusterCIDR, err) | ||
| } | ||
|
|
There was a problem hiding this comment.
Why are we moving this block outside the if ctx.IsControllerEnabled(nodeControllerName) blocks? Seems like we only need to do that in the case where the nodeController or routeController are enabled.
There was a problem hiding this comment.
yes,but they are always set to be enabled and if so we do not need to parse that and print same warning message twice
There was a problem hiding this comment.
fair enough. worst case, if someone has these controllers disabled, they get an extra warning
There was a problem hiding this comment.
I think I have a preference not to do this, also. Each of these if blocks should logically be its own function, and moving this up here makes them less self contained. And given that this happens once on startup, and that CIDR parsing isn't particularly computationally intensive, this isn't really an efficiency win, either.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
ping @lavalamp. Could I get the approve label ? |
k8s-github-robot
added
size/S
|
/lgtm (for future reference, I think these little spell check PRs are more trouble than they're worth.) |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: NickrenREN, lavalamp, sjenning
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
Automatic merge from submit-queue (batch tested with PRs 43870, 30302, 42722, 43736) |
Release note: