Update busybox dependency to fix bazel build #43766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-github-robot
added
size/XS
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ixdy, mikedanese
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
mikedanese
added
the
approved
|
@k8s-bot gce etcd3 e2e test this |
|
@k8s-bot gce etcd3 e2e test this |
1 similar comment
|
@k8s-bot gce etcd3 e2e test this |
|
Automatic merge from submit-queue |
|
We need to cherrypick this. |
mintzhao
pushed a commit
to mintzhao/kubernetes
that referenced
this pull request
Jun 1, 2017
…pick-of-#43766-release-1.6 Automatic merge from submit-queue Automated cherry pick of kubernetes#43766 release 1.6 Automated cherry pick of kubernetes#43766 release 1.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: the upstream busybox deb has been updated, and the old one no longer exists. This fixes the bazel build for users who haven't already downloaded the old deb into their workspace.
Special notes for your reviewer: we really need to figure out a better long-term strategy for this. The release branches are broken now too, and I don't want to have to cherry-pick fixes like this everywhere.
Release note:
/assign @mikedanese @spxtr