Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ListMetaFor #43802

Merged
merged 1 commit into from
Apr 7, 2017
Merged

remove ListMetaFor #43802

merged 1 commit into from
Apr 7, 2017

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Mar 29, 2017

Finish replacing ListMetaFor with ListAccessor. This gives more flexibility for list handling as intended. UnstructuredList matches now.

@kubernetes/sig-api-machinery-pr-reviews

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 29, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Mar 29, 2017
@deads2k deads2k unassigned ghost Mar 29, 2017
@deads2k deads2k assigned ncdc and foxish and unassigned krousey Mar 29, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Mar 29, 2017

@erictune @foxish this is moving us down the path for cleaner TPRs. It's hard to see, but we need it for a more managable reststorage path.

@deads2k
Copy link
Contributor Author

deads2k commented Mar 29, 2017

@k8s-bot non-cri e2e test this

@foxish
Copy link
Contributor

foxish commented Mar 30, 2017

@deads2k Change looks like a nop and cleaner. However, I'm finding it hard to see how it helps us towards a manageable reststorage path. Is this part of a series of changes that help us towards that?

@deads2k
Copy link
Contributor Author

deads2k commented Mar 30, 2017

@deads2k Change looks like a nop and cleaner. However, I'm finding it hard to see how it helps us towards a manageable reststorage path. Is this part of a series of changes that help us towards that?

Yeah, I'm push on our generic RESTStorage and finding places where it doesn't work on generic runtime.Objects. This is one of those fixes and I thought it could stand on its own.

@foxish
Copy link
Contributor

foxish commented Mar 30, 2017

/lgtm

Thanks for explaining the intent here.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, foxish

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Mar 30, 2017
@apelisse
Copy link
Member

apelisse commented Apr 7, 2017

@deads2k Can you please fix the release-note label?

@apelisse apelisse added release-note-none Denotes a PR that doesn't merit a release note. release-note-label-needed and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Apr 7, 2017
@apelisse
Copy link
Member

apelisse commented Apr 7, 2017

(sorry, changed the wrong PR)

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 44119, 42538, 43802, 42336, 43396)

@k8s-github-robot k8s-github-robot merged commit 51301d8 into kubernetes:master Apr 7, 2017
@deads2k deads2k deleted the api-07-listfor branch August 3, 2017 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ncdc ncdc

@foxish foxish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@deads2k @k8s-reviewable @foxish @k8s-github-robot @apelisse @ncdc @krousey @k8s-ci-robot