-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make get-kube.sh work properly the "ci/latest" pointer #44064
Conversation
cc @zreigz |
LGTM |
cluster/get-kube.sh
Outdated
echo "Version doesn't match regexp" >&2 | ||
exit 1 | ||
fi | ||
|
||
export KUBERNETES_RELEASE_URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this var used elsewhere? Why is it exported now if it wasn't before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to set it in the environment for get-kube-binaries.sh to work properly for ci builds.
I reworked this a bit so we only inject it in the environment when calling get-kube-binaries.sh.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ixdy, roberthbailey
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
@k8s-bot cvm gce e2e test this |
seriously? |
Automatic merge from submit-queue |
What this PR does / why we need it: this is a (late) followup from #36419, fixing a bug discovered in #36419 (comment).
Basically,
get-kube-binaries.sh
looks at$KUBERNETES_RELEASE_URL
, but we weren't properly overriding it inget-kube.sh
when downloading binaries from the CI release bucket. With this change, we set the variable correctly, and everything works:Release note: