Automated cherry pick of #44108 #44290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Federation control plane issues a delete command unless it wants to orphan the underlying per-cluster resource. When issuing that command, always set the orphanDependents to false.
k8s-github-robot
added
approved
|
The 'parent' PR of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement. (release-note-experimental must be explicit for cherry-picks) |
k8s-ci-robot
added
the
cncf-cla: yes
nikhiljindal
added
release-note-none
|
This change is |
|
@k8s-bot gce etcd3 e2e test this |
|
Does this fix a regression or broken use case? If so, please explain or link to the bug. |
|
This fixes a bug in federation cascading deletion. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikhiljindal, shashidharatd
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
enisoc
added
cherry-pick-approved
|
Automatic merge from submit-queue |
mintzhao
pushed a commit
to mintzhao/kubernetes
that referenced
this pull request
Jun 1, 2017
…y-pick-of-#44108-upstream-release-1.6 Automatic merge from submit-queue Automated cherry pick of kubernetes#44108 Cherry pick of kubernetes#44108 on release-1.6. kubernetes#44108: fed: Disable orphaning of per-cluster resources on deletion. ```release-note Fix for [federation failing to propagate cascading deletion](kubernetes#44304). ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #44108 on release-1.6.
#44108: fed: Disable orphaning of per-cluster resources on deletion.