Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Federation][Kubefed] Bug fix to enable disabling federation controllers through override args #44341

Merged
merged 1 commit into from
Apr 11, 2017
Merged

[Federation][Kubefed] Bug fix to enable disabling federation controllers through override args #44341

merged 1 commit into from
Apr 11, 2017

Conversation

irfanurrehman
Copy link
Contributor

@irfanurrehman irfanurrehman commented Apr 11, 2017 •
edited by enisoc

Targets #42761

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
#42761

Special notes for your reviewer:
PR #44209 is merged to master.
This fix needs to be cherry-picked to release-1.6 also.

Release note:

Fix for [disabling federation controllers through override args](https://github.com/kubernetes/kubernetes/issues/42761).

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 11, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Apr 11, 2017
@enisoc enisoc added approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-none Denotes a PR that doesn't merit a release note. labels Apr 11, 2017
@enisoc enisoc added this to the v1.6 milestone Apr 11, 2017
@enisoc
Copy link
Member

enisoc commented Apr 11, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: enisoc, irfanurrehman
We suggest the following additional approver: @csbell

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 878e9ca into kubernetes:release-1.6 Apr 11, 2017
mintzhao pushed a commit to mintzhao/kubernetes that referenced this pull request Jun 1, 2017
Merge pull request kubernetes#44341 from irfanurrehman/kubefed-fix-re…
6ea7925 
…lease-1.6

Automatic merge from submit-queue

[Federation][Kubefed] Bug fix to enable disabling federation controllers through override args

Targets kubernetes#42761

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
kubernetes#42761

**Special notes for your reviewer**:
PR kubernetes#44209 is merged to master.
This fix needs to be cherry-picked to release-1.6 also.

**Release note**:

```release-note
Fix for [disabling federation controllers through override args](kubernetes#42761).
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marun marun

@enisoc enisoc

@csbell csbell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@irfanurrehman @k8s-reviewable @enisoc @k8s-github-robot @marun @k8s-ci-robot @csbell