Use auto mode networks instead of legacy networks in GCP #44363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use of the --range flag creates legacy networks in GCP.
|
This change is |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
size/XS
|
@k8s-bot node e2e test this |
|
/assign @thockin |
k8s-github-robot
added
release-note-none
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, thockin
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
Automatic merge from submit-queue |
|
@bowei Can we change this further to create a custom network and create a child subnetwork? This would stop our quota issues whenever a region is added. I believe it'll also enable us to catch more bugs for features which require specifying subnets (ie ILB). |
|
@nicksardo I think the e2e tests already create a new network for each test, what specifically did you have in mind? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of the --range flag creates legacy networks in GCP.
Legacy networks will not support new GCP features.