[Federation] Fix the comments on FederationNameAnnotation

[perotinus]

Follow-up for minor issues raised in #42683

NONE

[k8s-ci-robot]

Hi @perotinus. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[perotinus]

@madhusudancs Currently, I've been annotating objects in both the host and joining clusters. Do we just want to annotate objects in the joining cluster?

[k8s-reviewable]

This change is 

[perotinus]

cc @madhusudancs

[madhusudancs]

A minor nit.

---

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

federation/apis/federation/annotations.go, line 20 at r1 (raw file):

// FederationNameAnnotation is the annotation which holds the name of
// the federation that that a federation control plane component is associated

s/that that/that/

---

federation/apis/federation/annotations.go, line 22 at r1 (raw file):

Previously, perotinus (Jonathan MacMillan) wrote…

@madhusudancs Currently, I've been annotating objects in both the host and joining clusters. Do we just want to annotate objects in the joining cluster?

We definitely want to annotate objects in the host cluster. We create a number of objects in the host cluster and we want to keep track of them.

Annotating objects in the joining cluster is useful too, esp. if the cluster is part of multiple federations. Feel free to fix the doc string accordingly.

---

Comments from Reviewable

[perotinus]

Review status: 0 of 1 files reviewed at latest revision, 2 unresolved discussions.

---

federation/apis/federation/annotations.go, line 20 at r1 (raw file):

Previously, madhusudancs (Madhusudan.C.S) wrote…

s/that that/that/

D'oh. Fixed.

---

federation/apis/federation/annotations.go, line 22 at r1 (raw file):

Previously, madhusudancs (Madhusudan.C.S) wrote…

We definitely want to annotate objects in the host cluster. We create a number of objects in the host cluster and we want to keep track of them.

Annotating objects in the joining cluster is useful too, esp. if the cluster is part of multiple federations. Feel free to fix the doc string accordingly.

Oh, yes, of course! I think that's what I meant to say.

---

Comments from Reviewable

[nikhiljindal]

@k8s-bot ok to test

[madhusudancs]

/lgtm
/approve

---

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

Comments from Reviewable

[k8s-github-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: madhusudancs, perotinus

Needs approval from an approver in each of these OWNERS Files:

• federation/OWNERS [madhusudancs]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

[k8s-github-robot]

Automatic merge from submit-queue (batch tested with PRs 44607, 44472, 44482)