Edge based services in proxy #44499
Merged
Edge based services in proxy #44499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
approved
wojtek-t
added
release-note-none
wojtek-t
added
cncf-cla: yes
|
This change is |
ncdc
reviewed
Apr 17, 2017
pkg/proxy/config/config.go
Outdated
| @@ -45,7 +45,24 @@ type ServiceConfigHandler interface { | |||
| OnServiceUpdate(services []*api.Service) | |||
| } | |||
|
|
|||
| // EndpointsHandler is an abstract interface o objects which receive | |||
| // ServiceHandler is an abstract interface of objects whic receive | |||
k8s-github-robot
added
the
needs-rebase
wojtek-t
force-pushed
the
edge_based_services_in_proxy
branch
from
fecdd15
to
d7a54dd
Compare
k8s-github-robot
removed
the
needs-rebase
wojtek-t
force-pushed
the
edge_based_services_in_proxy
branch
from
d7a54dd
to
8b67d27
Compare
wojtek-t
force-pushed
the
edge_based_services_in_proxy
branch
from
8b67d27
to
7a647f9
Compare
|
/lgtm |
|
@thockin - any reason why you closed this? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thockin, wojtek-t
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
wojtek-t
added
the
lgtm
|
Automatic merge from submit-queue |
|
@wojtek-t: The following test(s) failed:
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is sibling effort to what I did for endpoints in KubeProxy.
This PR is first one (changing config & iptables) - userspace will follow.