Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controller: fix saturation check for Deployments #44616

Merged
merged 1 commit into from
Apr 25, 2017
Merged

controller: fix saturation check for Deployments #44616

merged 1 commit into from
Apr 25, 2017

Conversation

0xmichalis
Copy link
Contributor

@0xmichalis 0xmichalis commented Apr 18, 2017 •
edited

Cherry-pick of #44439

Signed-off-by: Michail Kargakis mkargaki@redhat.com

Fix for [scaling down remaining good replicas when a failed Deployment is paused](https://github.com/kubernetes/kubernetes/issues/44436).

@0xmichalis 0xmichalis added this to the v1.6 milestone Apr 18, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 18, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Apr 18, 2017
@0xmichalis 0xmichalis added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Apr 18, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@0xmichalis 0xmichalis changed the title controller: remove saturation check from Deployments controller: fix saturation check for Deployments Apr 20, 2017
@0xmichalis
controller: fix saturation check for Deployments
65ec4b8 
Signed-off-by: Michail Kargakis <mkargaki@redhat.com>
@enisoc enisoc added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-none Denotes a PR that doesn't merit a release note. labels Apr 25, 2017
@enisoc
Copy link
Member

enisoc commented Apr 25, 2017

@Kargakis I've added a release note. Please take a look to make sure it's accurate.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enisoc, kargakis

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@0xmichalis
Copy link
Contributor Author

thanks @enisoc , looks fine

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit b810ea1 into kubernetes:release-1.6 Apr 25, 2017
@0xmichalis 0xmichalis deleted the backport-to-16 branch April 25, 2017 18:13
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.6" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@janetkuo janetkuo

@enisoc enisoc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@0xmichalis @k8s-reviewable @enisoc @k8s-github-robot @k8s-cherrypick-bot @janetkuo @k8s-ci-robot