Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more metadata about dynamically provisioned PVs using PV annotation #44669

Merged
merged 1 commit into from
May 4, 2017
Merged

Add more metadata about dynamically provisioned PVs using PV annotation #44669

merged 1 commit into from
May 4, 2017

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Apr 19, 2017

This patch add below fields to Gluster dynamic pvs.

"Description: "Gluster: dynamically provisioned PVs"
"Creator": "heketi-dynamic"
"Type": "file"

Signed-off-by: Humble Chirammal hchiramm@redhat.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 19, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @humblec. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 19, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Apr 19, 2017
@humblec
Copy link
Contributor Author

humblec commented Apr 19, 2017

@k8s-bot test this.

@k8s-ci-robot
Copy link
Contributor

@humblec: you can't request testing unless you are a kubernetes member.

In response to this:

@k8s-bot test this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@humblec
Copy link
Contributor Author

humblec commented Apr 19, 2017

@rootfs @jsafrane Can you please trigger tests on this ?

@spxtr
Copy link
Contributor

spxtr commented Apr 20, 2017

/assign @rootfs @jsafrane
/unassign @jingxu97
@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 20, 2017
@k8s-ci-robot k8s-ci-robot assigned jsafrane and rootfs and unassigned jingxu97 Apr 20, 2017
@humblec
Copy link
Contributor Author

humblec commented Apr 27, 2017 •
edited

@jsafrane @rootfs please review :)

@rootfs
Copy link
Contributor

rootfs commented May 3, 2017

refer to this format for consistency

@humblec
Copy link
Contributor Author

humblec commented May 4, 2017

@rootfs Addressed the comment. Thanks!

rootfs
rootfs reviewed May 4, 2017
View reviewed changes
pkg/volume/glusterfs/glusterfs.go Outdated

pv.Annotations = map[string]string{
volumehelper.VolumeGidAnnotationKey: gidStr,
"Creator": "heketi-dynamic",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"kubernetes.io/createdby": "heketi-dynamic-provisioner",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Done.

rootfs
rootfs reviewed May 4, 2017
View reviewed changes
pkg/volume/glusterfs/glusterfs.go Outdated
pv.Annotations = map[string]string{
volumehelper.VolumeGidAnnotationKey: gidStr,
"Creator": "heketi-dynamic",
"Type": "file",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put type in a heketi namespace if possible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placed in gluster namespace.. Done

@humblec
Add more metadata about dynamically provisioned PVs using
1d17c0c 
PV annotation:

This patch add below fields to Gluster dynamic pvs:

   "Description: "Gluster: dynamically provisioned PV"
   "Creator": "heketi-dynamic"
   "Type": "file"

Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@humblec
Copy link
Contributor Author

humblec commented May 4, 2017

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels May 4, 2017
@rootfs
Copy link
Contributor

rootfs commented May 4, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: humblec, rootfs

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2017
@humblec
Copy link
Contributor Author

humblec commented May 4, 2017

Thanks a lot @rootfs!

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 45081, 44669)

@k8s-github-robot k8s-github-robot merged commit ca520e3 into kubernetes:master May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rootfs rootfs rootfs left review comments

Assignees

@jsafrane jsafrane

@rootfs rootfs

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@humblec @k8s-reviewable @k8s-ci-robot @spxtr @rootfs @k8s-github-robot @jsafrane @jingxu97