Allow summaries to be printed out to ReportDir instead of stdout #44673
Conversation
gmarek
added
the
release-note-none
k8s-github-robot
added
the
approved
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
the
size/M
|
This change is |
test/e2e/framework/framework.go
Outdated
| if TestContext.ReportDir == "" { | ||
| Logf(summaries[i].PrintHumanReadable()) | ||
| } else { | ||
| filePath := path.Join(TestContext.ReportDir, summaries[i].SummaryKind()+now.Format(time.RFC3339)+".txt") |
There was a problem hiding this comment.
I'm fine with that for now, but can you please add a TODO to add test name here?
There was a problem hiding this comment.
or actually replace time with test name?
There was a problem hiding this comment.
Done. It may be tricky though, as you certainly don't want to append "should allow starting 30 pods per node using { ReplicationController} with 0 secrets and 0 daemons" (aka "Density") which is what you would get...
There was a problem hiding this comment.
Good point. What we want is the "KubeDescribe" part of it. Anyway. TODO is fine.
test/e2e/framework/framework.go
Outdated
| Logf("%v JSON\n%v", summaries[i].SummaryKind(), summaries[i].PrintJSON()) | ||
| Logf("Finished") | ||
| } else { | ||
| filePath := path.Join(TestContext.ReportDir, summaries[i].SummaryKind()+now.Format(time.RFC3339)+".json") |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gmarek, wojtek-t
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue (batch tested with PRs 44667, 44673) |
Fix #44003
cc @shyamjvs