Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry in get-kube.sh to avoid download flakes. #44689

Merged
merged 1 commit into from
Apr 20, 2017

Conversation

rmmh
Copy link
Contributor

@rmmh rmmh commented Apr 19, 2017

GCS has up to 2% 5xx rates, so retrying is critical.

This is currently failing about 8 times per day according to the dashboard. It could be backported to reduce the flake rate.

Relase note:

NONE

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 19, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Apr 19, 2017
@csbell
Copy link
Contributor

csbell commented Apr 19, 2017

Thanks Ryan!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2017
@mikedanese
Copy link
Member

/lgtm

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csbell, mikedanese, rmmh

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 44687, 44689, 44661)

@k8s-github-robot k8s-github-robot merged commit 6d67cdd into kubernetes:master Apr 20, 2017
@rmmh rmmh deleted the avoid-get-kube-dl-flake branch May 12, 2017 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants