Redirect some test spam to files instead of main log files #44722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
gmarek
added
the
release-note-none
k8s-github-robot
added
approved
|
This change is |
gmarek
changed the title
wojtek-t
reviewed
Apr 20, 2017
test/e2e/framework/framework.go
Outdated
| file, err := os.Create(filePath) | ||
| if err != nil { | ||
| Logf("Failed to create a file with image-puller data %v: %v", filePath, err) | ||
| return |
There was a problem hiding this comment.
Change to else - otherwise you will loose everything that is running later.
[The same you did above]
gmarek
force-pushed
the
netstat_to_file
branch
2 times, most recently
from
0609841
to
86fcc8c
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-github-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gmarek, wojtek-t
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
LGTM |
|
Hmm.. For some reason the "Jenkins GCE e2e" test is showing green on Github, but SQ is reporting it isn't green. Kicking it to see if it'll pick up. |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #44707
@kubernetes/test-infra-maintainers @wojtek-t