Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update gophercloud that fixed code format #44844

Merged
merged 1 commit into from
Jun 3, 2017
Merged

update gophercloud that fixed code format #44844

merged 1 commit into from
Jun 3, 2017
+161 −91

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented Apr 24, 2017

What this PR does / why we need it:

mainly to include #265, which fixed the code format including below two files:

  • vendor/github.com/gophercloud/gophercloud/openstack/blockstorage/v1/apiversions/urls.go
  • vendor/github.com/gophercloud/gophercloud/openstack/compute/v2/images/results.go

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 24, 2017
@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels Apr 24, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @dixudx. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 24, 2017
zetaab
zetaab suggested changes Apr 24, 2017
View reviewed changes
Copy link
Member

@zetaab zetaab left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you execute make verify? This PR should contain modifications to file staging/src/k8s.io/apiserver/Godeps/Godeps.json as well (because it has dependency to gophercloud). PR should modify version number in that file, but I cannot see that.

You can update those running ./hack/update-staging-godeps.sh if I remember correctly

@cblecker
Copy link
Member

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 25, 2017
@cblecker
Copy link
Member 

W0424 17:54:04.728] 30 BUILD files not up-to-date.
I0424 17:54:04.828] 
I0424 17:54:04.828] Run ./hack/update-bazel.sh
I0424 17:54:04.828] FAILED   hack/make-rules/../../hack/verify-bazel.sh	5s

@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 25, 2017
@dixudx
Copy link
Member Author

dixudx commented Apr 25, 2017

@zetaab need your label lgtm

@cblecker
Copy link
Member

/assign @anguslees
This pertains to the openstack cloudprovider

@zetaab
Copy link
Member

zetaab commented Apr 25, 2017

/lgtm

@k8s-ci-robot
Copy link
Contributor

@zetaab: changing LGTM is restricted to assignees, and only kubernetes org members may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@anguslees
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Apr 26, 2017
@anguslees
Copy link
Member

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Apr 26, 2017
@dixudx
Copy link
Member Author

dixudx commented May 31, 2017

@k8s-bot verify test this

@dchen1107
Copy link
Member

/lgtm

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anguslees, dchen1107, dixudx, zetaab

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2017
@dixudx
Copy link
Member Author

dixudx commented Jun 1, 2017

@anguslees Please remove do-not-merge label. Thanks.

@anguslees
Copy link
Member

@dixudx I don't think I am able to do that :/

@idvoretskyi Any ideas why the do-not-merge label was added, and what we can do to remove it?

@luxas luxas removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Jun 1, 2017
@calebamiles calebamiles modified the milestone: v1.7 Jun 2, 2017
@dims
Copy link
Member

dims commented Jun 2, 2017

@dixudx Will you be able to update this PR please? Thanks!

@dixudx
Copy link
Member Author

dixudx commented Jun 3, 2017

@k8s-bot pull-kubernetes-unit test this

@dixudx
Copy link
Member Author

dixudx commented Jun 3, 2017

@k8s-bot pull-kubernetes-verify test this

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 3, 2017 •
edited

@dixudx: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
Jenkins verification 47442f1 link @k8s-bot verify test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dixudx
Copy link
Member Author

dixudx commented Jun 3, 2017

@k8s-bot pull-kubernetes-e2e-kops-aws test this

@dixudx
Copy link
Member Author

dixudx commented Jun 3, 2017

@k8s-bot pull-kubernetes-unit test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 5b5b8e6 into kubernetes:master Jun 3, 2017
@dixudx dixudx deleted the update_gophercloud branch September 9, 2017 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetaab zetaab zetaab approved these changes

Assignees

@anguslees anguslees

@lavalamp lavalamp

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet