-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update troubleshooting link in ISSUE_TEMPLATE.md #44947
Update troubleshooting link in ISSUE_TEMPLATE.md #44947
Conversation
Hi @xiangpengzhao. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@@ -1,6 +1,6 @@ | |||
<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--> | |||
|
|||
**Is this a request for help?** (If yes, you should use our troubleshooting guide and community support channels, see http://kubernetes.io/docs/troubleshooting/.): | |||
**Is this a request for help?** (If yes, you should use our troubleshooting guide and community support channels, see https://kubernetes.io/docs/tasks/debug-application-cluster/troubleshooting/.): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the dot at the end of the URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@supereagle Thanks for your review! Since this is just a nit and Christoph has already LGTM'd and all the checks passed, let's leave it as is :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xiangpengzhao @supereagle I'm okay with it either way. It doesn't impact the link at all, so the period really doesn't matter. If you decide to remove it @xiangpengzhao, I don't mind re-LGTMing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Christoph ! I think let's leave the period here, since it's the end of this sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm also OK. Please go ahead.
@k8s-bot ok to test |
/lgtm |
@k8s-bot unit test this |
ping @brendandburns for approve :) |
@k8s-bot pull-kubernetes-federation-e2e-gce test this |
ping @brendandburns for approval |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, cblecker, xiangpengzhao
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue |
What this PR does / why we need it:
Since our troubleshooting page has been moved, we should update the issue template.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
ref: #44434
Release note: