Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHANGELOG.md: update outdated link #44949

Merged
merged 1 commit into from
May 3, 2017
Merged

CHANGELOG.md: update outdated link #44949

merged 1 commit into from
May 3, 2017

Conversation

zhangxiaoyu-zidif
Copy link
Contributor

@zhangxiaoyu-zidif zhangxiaoyu-zidif commented Apr 26, 2017 •
edited

I am not sure that if the file was generated automatically.
But I find some links were outdated.
Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 26, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @zhangxiaoyu-zidif. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 26, 2017
@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Apr 26, 2017
@cblecker
Copy link
Member

Updating 1.6 makes sense, but I don't think we need to go back and update links from 1.4, etc.

@zhangxiaoyu-zidif
Copy link
Contributor Author

@cblecker I am not sure that if it's worth updating these links. If you think it is unnecessary, that would be fine to close this PR. :).

@brendandburns
Copy link
Contributor

This seems fine to me, I agree with @cblecker wrt 1.4.

@brendandburns
Copy link
Contributor

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 27, 2017
@brendandburns brendandburns added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Apr 27, 2017
@zhangxiaoyu-zidif
Copy link
Contributor Author

@brendandburns Hi! I do not know what is wrt1.4. Dose it mean I need fix these links from v1.4 on. :)
Thanks for your reviewing.

@cblecker
Copy link
Member

cblecker commented May 1, 2017 •
edited

@zhangxiaoyu-zidif You've suggested changes around lines 1000-1006 and lines 1210-1213. Those are part of the 1.6 changelog. You've also suggested changes around 4517-4521, and 6243-6250. Those are in the 1.4 and 1.2 changelog sections. The 1.6 changes are fine, but please remove changes in the 1.4 and 1.2 sections. We don't want to change history that far back.

@zhangxiaoyu-zidif
Copy link
Contributor Author

@cblecker @brendandburns
PTAL

@zhangxiaoyu-zidif
Copy link
Contributor Author

@k8s-bot node e2e test this

@brendandburns
Copy link
Contributor

@zhangxiaoyu-zidif wrt == "with regards too" apologies, it's an english acronym, I should have been more verbose.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, zhangxiaoyu-zidif

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2017
@zhangxiaoyu-zidif
Copy link
Contributor Author

@brendandburns @cblecker Thank you！ you are both nice and kind~ ：）

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 3badd5f into kubernetes:master May 3, 2017
@cblecker cblecker mentioned this pull request Jul 27, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lavalamp lavalamp

@brendandburns brendandburns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@zhangxiaoyu-zidif @k8s-reviewable @k8s-ci-robot @cblecker @brendandburns @k8s-github-robot @lavalamp