-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Federation] Cleanup unused code in service controller #44960
[Federation] Cleanup unused code in service controller #44960
Conversation
@k8s-bot unit test this |
/lgtm |
@k8s-bot unit test this |
I'd rather not have us revert this. Until we have pre-merge testing, please invoke the bot (even though yes it looks like routine cleanup :-). |
@csbell, pre-merge tests for federation have already passed. https://k8s-gubernator.appspot.com/pr/44960 |
Apologies, had not seen it. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csbell, nikhiljindal, shashidharatd
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Automatic merge from submit-queue (batch tested with PRs 43395, 44960) |
Thanks @csbell, @nikhiljindal |
Post merging the PR #41258, lot of unused code is left behind in federation service controller. These changes were segregated to this PR, so that the original PR was small and manageable.
Release note:
cc @kubernetes/sig-federation-pr-reviews