Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Federation] Cleanup unused code in service controller #44960

Conversation

shashidharatd
Copy link

Post merging the PR #41258, lot of unused code is left behind in federation service controller. These changes were segregated to this PR, so that the original PR was small and manageable.

Release note:

NONE

cc @kubernetes/sig-federation-pr-reviews

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 26, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Apr 26, 2017
@shashidharatd
Copy link
Author

@k8s-bot unit test this

@nikhiljindal
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2017
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2017
@shashidharatd
Copy link
Author

@k8s-bot unit test this

@csbell
Copy link
Contributor

csbell commented Apr 26, 2017

I'd rather not have us revert this. Until we have pre-merge testing, please invoke the bot (even though yes it looks like routine cleanup :-).
@k8s-bot pull-kubernetes-federation-e2e-gce test this

@csbell csbell removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2017
@shashidharatd
Copy link
Author

@csbell, pre-merge tests for federation have already passed. https://k8s-gubernator.appspot.com/pr/44960

@csbell
Copy link
Contributor

csbell commented Apr 26, 2017

Apologies, had not seen it.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csbell, nikhiljindal, shashidharatd

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 43395, 44960)

@k8s-github-robot k8s-github-robot merged commit ed0adbf into kubernetes:master Apr 26, 2017
@shashidharatd
Copy link
Author

Thanks @csbell, @nikhiljindal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants