Add node e2e tests for hostIPC #45006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-github-robot
added
size/M
10 tasks
|
ping @Random-Liu @yujuhong |
yujuhong
reviewed
May 8, 2017
| BeforeEach(func() { | ||
| output, err := exec.Command("sh", "-c", "ipcmk -M 1M | awk '{print $NF}'").Output() | ||
| if err != nil { | ||
| framework.Failf("Create shared memory on the host failed: %v", err) |
There was a problem hiding this comment.
"Failed to create the shared memory on the host: %v"
|
|
||
| hostSharedMemoryID := "" | ||
| BeforeEach(func() { | ||
| output, err := exec.Command("sh", "-c", "ipcmk -M 1M | awk '{print $NF}'").Output() |
There was a problem hiding this comment.
Clean up the resource after the test.
|
@yujuhong Addressed comments. PTAL. |
|
/lgtm @Random-Liu ping for approval |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Random-Liu, feiskyer, yujuhong
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
Automatic merge from submit-queue (batch tested with PRs 45304, 45006, 45527) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add node e2e tests for hostIPC.
Which issue this PR fixes
Part of #44118.
Special notes for your reviewer:
Release note:
/assign @Random-Liu @yujuhong