Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add request count to APICall metric #45021

Merged
merged 1 commit into from
Apr 28, 2017
Merged

Add request count to APICall metric #45021

merged 1 commit into from
Apr 28, 2017

Conversation

shyamjvs
Copy link
Member

@shyamjvs shyamjvs commented Apr 27, 2017 •
edited

Ref #44701

This should add beside the API call latencies, the count of the requests.

cc @wojtek-t @gmarek

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 27, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Apr 27, 2017
@shyamjvs shyamjvs added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Apr 27, 2017
@shyamjvs shyamjvs mentioned this pull request Apr 27, 2017
Open
@foxish foxish assigned gmarek and unassigned foxish Apr 27, 2017
@shyamjvs
Copy link
Member Author

@gmarek Could you PTAL?

@fejta
Copy link
Contributor

fejta commented Apr 27, 2017

/unassign
/assign @gmarek @wojtek-t

@k8s-ci-robot k8s-ci-robot assigned wojtek-t and unassigned fejta Apr 27, 2017
@gmarek
Copy link
Contributor

gmarek commented Apr 28, 2017

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gmarek, shyamjvs

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2017
@gmarek
Copy link
Contributor

gmarek commented Apr 28, 2017

@k8s-bot unit test this

@shyamjvs
Copy link
Member Author

shyamjvs commented Apr 28, 2017 •
edited

@k8s-bot unit test this
(seems unrelated)

@shyamjvs
Copy link
Member Author

@k8s-bot unit test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 45033, 44961, 45021, 45097, 44938)

@k8s-github-robot k8s-github-robot merged commit 0132193 into kubernetes:master Apr 28, 2017
@shyamjvs shyamjvs deleted the add-request-count branch April 28, 2017 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmarek gmarek

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@shyamjvs @k8s-reviewable @fejta @gmarek @k8s-github-robot @foxish @wojtek-t @k8s-ci-robot